manage journals through sidebar + context menu #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloverich
force-pushed
the
cloverich/sidebar-context
branch
3 times, most recently
from
730060d to
cd5a715
Compare
- Move journal CRUD from its own page to the sidebar, driven by a context menu - Remove journal management page / header link - Add radix dependencies (colors, context menu, dialog) - Implement a Sidesheet (shadcn) and replace evergreen-ui based sidesheet - Add basic name validation for journals
cloverich
force-pushed
the
cloverich/sidebar-context
branch
from
cd5a715 to
cfb5373
Compare
cloverich
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal was to make journal management a bit more folder nav like, with a sub-goal of using it to get a basic context menu going. Also realized evergreen-ui has become unmaintained, which was motivation to begin moving it out. Will replace with radix and shadcn or fully custom components, as part of design sprint.
This PR intentionally does minimal design wise, and focuses on getting it working. Moved state over to mobx after some back and forth; uncommitted on mobx or even naming patterns at this point, but going to try hard and ignore that for a while, focusing on features and design instead.
Action buttons from the prior screen moved to context menu.
Renaming / Add uses an inline input to toggle only journal feature you edit (the name). Also added some validation to name (max length, empty string check).
Closes #187