generated from proofoftom/buidler-waffle-typechain-quasar
-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add email form for recipient registration #539
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow recipient registry owner to add recipients for simple recipient registry type
auryn-macmillan
approved these changes
Aug 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
I could remove the category for this PR.
Allowing owner to define categories is a good idea. In fact, may be have a separate PR to allow owner to define any fields?
… On Aug 8, 2022, at 10:10 AM, Auryn Macmillan ***@***.***> wrote:
I wonder if we should either remove the categories or allow the owner to define them somehow? These were specific to the ETHStaker round and might not make sense in other contexts.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were assigned.
|
I think this is fine.
Yeah, doing it as a separate feature and PR makes sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
If the VUE_APP_GOOGLE_SPREADSHEET_ID environment variable is set, users will be asked to provide email on the recipient registration flow. This fixes Add a new step to accept recipient email for the recipient registration process #516
Added recipient registration form validation
Removed universal recipient registry, use existing optimistic recipient registry instead
Moved the transaction submit button on the Metadata form submission widget to the Form Navigation Panel.