Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add email form for recipient registration #539

Merged
merged 37 commits into from
Aug 11, 2022

Conversation

yuetloo
Copy link
Collaborator

@yuetloo yuetloo commented Aug 3, 2022

Changes:

  • If the VUE_APP_GOOGLE_SPREADSHEET_ID environment variable is set, users will be asked to provide email on the recipient registration flow. This fixes Add a new step to accept recipient email for the recipient registration process #516

  • Added recipient registration form validation

  • Removed universal recipient registry, use existing optimistic recipient registry instead

  • Moved the transaction submit button on the Metadata form submission widget to the Form Navigation Panel.

@auryn-macmillan
Copy link
Member

image
I wonder if we should either remove the categories or allow the owner to define them somehow? These were specific to the ETHStaker round and might not make sense in other contexts.

Copy link
Member

@auryn-macmillan auryn-macmillan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yuetloo
Copy link
Collaborator Author

yuetloo commented Aug 8, 2022 via email

@auryn-macmillan
Copy link
Member

I could remove the category for this PR.

I think this is fine.

Allowing owner to define categories is a good idea. In fact, may be have a separate PR to allow owner to define any fields?

Yeah, doing it as a separate feature and PR makes sense.

@yuetloo yuetloo merged commit 8915a0e into feature/metadata Aug 11, 2022
@yuetloo yuetloo deleted the feature/recipient-email branch August 11, 2022 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a new step to accept recipient email for the recipient registration process
2 participants