Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to webdav-client V5 #65

Open
n-peugnet opened this issue Jan 11, 2024 · 1 comment
Open

Upgrade to webdav-client V5 #65

n-peugnet opened this issue Jan 11, 2024 · 1 comment
Labels
blocked This issue is blocked by something dependencies Pull requests that update a dependency file enhancement New feature or request

Comments

@n-peugnet
Copy link
Member

n-peugnet commented Jan 11, 2024 •
edited
Loading

webdav-client v5 has some breaking changes that affect us quite a lot:

Breaking changes:

[...]

[...]

A workaround is suggested, by using a ReadableStream in the body of the Request element but this is not supported by Firefox nor Safari as to now12.

See also:

Footnotes

  1. https://developer.mozilla.org/en-US/docs/Web/API/Request/Request#browser_compatibility, look for the "Send ReadableStream in request body" in the compatibility table ↩

  2. https://caniuse.com/mdn-api_request_request_request_body_readablestream ↩
@n-peugnet n-peugnet added enhancement New feature or request blocked This issue is blocked by something dependencies Pull requests that update a dependency file labels Jan 11, 2024
n-peugnet added a commit to club-1/webdav-server that referenced this issue Jan 11, 2024
@n-peugnet
Prepare support for partial updates
807b000 
As webdav-client may support it one day. And thus WebDAV-Drive also,
when we manage to implement the upload progress over fetch.

See: perry-mitchell/webdav-client#362, club-1/webdav-drive#65
@ArcticLampyrid
Copy link
Contributor

Note that fetch with ReadableStream is not supported with HTTP 1.x

https://developer.chrome.com/docs/capabilities/web-apis/fetch-streaming-requests?hl=en

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked This issue is blocked by something dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ArcticLampyrid @n-peugnet