Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation about 'nginx reverse proxy' is at least misleading #195

Closed
virtuelle-maschine opened this issue Oct 15, 2022 · 2 comments · Fixed by #251
Closed

Documentation about 'nginx reverse proxy' is at least misleading #195

virtuelle-maschine opened this issue Oct 15, 2022 · 2 comments · Fixed by #251
Labels
documentation Improvements or additions to documentation

Comments

@virtuelle-maschine
Copy link

I have tried to build a setup with two services: one framework-x service and a nginx as reverse proxy.
If I am using the nginx configuration that you are suggesting (https://framework-x.org/docs/best-practices/deployment/#nginx-reverse-proxy), all php files in the public folder are served "as-it" (unparsed) to the client (at least if nginx and framework-x are sharing the same public folder - but that is how I read your examples).
Seems to me that using a different path for the the framework-x start script than /public/index.php is highly recommended. Or am I missing something?

I have created an example in a branch of my test project: https://github.com/virtuelle-maschine/framework-x-test/tree/example-with-index
An example that works as expected can be found in the main branch of that project.

BTW, regarding Dockerfile: I am surprised you are using the ENTRYPOINT instruction to start the app - doesn't the CMD instruction makes more sense as you can run the container with a different command (e.g. composer) much easier?

@virtuelle-maschine virtuelle-maschine added the bug Something isn't working label Oct 15, 2022
@SimonFrings
Copy link
Contributor

@virtuelle-maschine Thanks for bringing this up 👍

Seems to me that using a different path for the the framework-x start script than /public/index.php is highly recommended. Or am I missing something?

I agree, the documentation can definitely be improved there, if you have any suggestions we are always happy about PRs, I wrote a contribution chapter for our readme a while ago, in there are instructions on how to work on the documentation.

BTW, regarding Dockerfile: I am surprised you are using the ENTRYPOINT instruction to start the app - doesn't the CMD instruction makes more sense as you can run the container with a different command (e.g. composer) much easier?

This makes actually no difference in our case. If you think it is necessary to tackle this topic, we're happy to hear your thoughts on this, or you can suggest changes via a pull request.

@virtuelle-maschine
Copy link
Author

@SimonFrings Thanks for your reply! Created PR #197 to fix the nginx reverse proxy configuration.

@clue clue added documentation Improvements or additions to documentation and removed bug Something isn't working labels Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants