Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent serving unparsed php files via nginx proxy. #197

Conversation

virtuelle-maschine
Copy link

Currently, if using nginx as a reverse proxy with the described configuration, PHP files in the public folder are served as-it (unparsed) to the client, because the try_files instruction in the nginx configuration finds the file (e.g. index.php). To avoid this behavior we must instruct nginx to pass any file ending with .php as a route to X. That does not mean that X will parse this file, and as long as not appropriate route is defined (e.g. $app->get('/index.php', ...) X will just respond with a 404 error page, but at least no PHP code is leaked.

@clue clue added the documentation Improvements or additions to documentation label Oct 19, 2022
@clue
Copy link
Owner

clue commented Oct 19, 2022

@virtuelle-maschine Thank you for looking into this, I agree that the existing documentation looks wrong.

It looks like your suggested changes would address this particular problem, but I wonder how we could ensure we have a configuration that is well tested and covers all basic needs? I would love to have some more input and/or some overview what configuration other projects recommend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants