Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use composer.lock required packages instead of vendor/installed.json #50

Closed
wants to merge 2 commits into from
Closed

Use composer.lock required packages instead of vendor/installed.json #50

wants to merge 2 commits into from

Conversation

Grisou13
Copy link

Using composer.lock to laod the packages allows to not require dev dependencies (PHPUnit is big as dep so don't put it if we don't need it in the actual builded phar)

@Grisou13 Grisou13 changed the title Used composer.lock required packages Use composer.lock required packages instead of vendor/installed.json Aug 31, 2015
@clue
Copy link
Owner

clue commented Nov 15, 2015

Thanks for your PR @Grisou13, I agree that dev dependencies should not be installed 👍 Have you seen #37 already? I believe these two PRs are somewhat similar.

I've also raised several issues we should be aware of in #37, what are you thoughts about this?

@clue
Copy link
Owner

clue commented Jun 29, 2016

Thanks for filing this PR @Grisou13! Unfortunately, this PR is currently incomplete and hasn't seen any updates in some time.

Please see #61 and consider helping the discussion. I'll close this for now until the outstanding issues have been resolved. Please let me know if you plan on updating this and I'll happily reopen 👍

@clue clue closed this Jun 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants