Expand Symfony version constraints to include 3.x and 4.x #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove composer.lock file from version management, since it can be built against multiple versions of Symfony
clue
reviewed
Apr 23, 2019
There was a problem hiding this comment.
@chris-hamper Thanks for filing this PR!
The changeset currently builds on top of #81. Other than that, it looks like the only real change in here would be version constraints? How can we best verify this project works with all given versions of symfony/console?
|
@chris-hamper Thank you for this PR, I've filed #85, #86 and #87 which include most of your changes and also include a simple test case to verify installation works alongside newer Symfony versions 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds upon PR #81