Update CI setup to ensure 100% code coverage

clue · Dec 1, 2022 · 56a511b · 56a511b
1 parent 2cf9795
commit 56a511b
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -31,7 +31,14 @@ jobs:
           coverage: xdebug
           ini-file: development
       - run: composer install
-      - run: vendor/bin/phpunit --coverage-text
+      - run: docker pull busybox:latest
+      - run: vendor/bin/phpunit --coverage-text --coverage-clover=clover.xml
         if: ${{ matrix.php >= 7.3 }}
-      - run: vendor/bin/phpunit --coverage-text -c phpunit.xml.legacy
+      - run: vendor/bin/phpunit --coverage-text --coverage-clover=clover.xml -c phpunit.xml.legacy
         if: ${{ matrix.php < 7.3 }}
+      - name: Check 100% code coverage
+        shell: php {0}
+        run: |
+          <?php
+          $metrics = simplexml_load_file('clover.xml')->project->metrics;
+          exit((int) $metrics['statements'] === (int) $metrics['coveredstatements'] ? 0 : 1);
diff --git a/tests/FunctionalClientTest.php b/tests/FunctionalClientTest.php
@@ -90,8 +90,7 @@ public function testCreateStartAndRemoveContainer()
         // get all events between starting and removing for this container
         $promise = $this->client->events($start, $end, array('container' => array($container['Id'])));
         $ret = \React\Async\await($promise);
-
-        $this->assertIsArray($ret);
+        assert(is_array($ret));
 
         $status = array(); // array_column($ret, 'status'); // PHP 5.5+
         foreach ($ret as $one) {