Run tests on PHPUnit 9 #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonFrings
force-pushed
the
tests
branch
2 times, most recently
from
f962595 to
2ad7f23
Compare
clue
reviewed
Jul 29, 2020
tests/TestCase.php
Outdated
| @@ -48,7 +48,13 @@ protected function expectCallableOnceParameter($type) | |||
|
|
|||
| protected function createCallableMock() | |||
| { | |||
| return $this->getMockBuilder('stdClass')->setMethods(array('__invoke'))->getMock(); | |||
| if (method_exists('PHPUnit\Framework\MockObject\MockBuilder', 'addMethods')) { | |||
| // PHPUnit 10+ | |||
There was a problem hiding this comment.
Whops, I meant PHPUnit 8.5.0+ 😅
SimonFrings
force-pushed
the
tests
branch
3 times, most recently
from
a74e1b4 to
86dd845
Compare
clue
approved these changes
Jul 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.