-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use reactphp/async instead of clue/reactphp-block #77
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for opening this up 👍
I've added some comments below, can you also add references to your PR message like I did in clue/reactphp-mq#34 so we can keep track of where this is coming from
Oh.. it was a bit late when I did this and I used multiple selections to do the edits, now everything should be resolved thanks for the review 👍🏼 |
5c9898c
to
065c764
Compare
Added a timeout to the |
I stumbled over this behavior in reactphp/socket#283, some tests got stuck in execution because of other tests that didn't close their servers/connections. Seems like this is the same case here. I would suggest we look into this in a different pull request, afterwards we can come back to this one. |
I will look into your solution and open a new PR to fix this 👍🏼 |
399d3c4
to
135939e
Compare
Should be ready now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just two little things I noticed, first the timeout in the ci.yml
can be removed as I suggested below and there's a $loop = Loop::get();
inside the last test in tests/IntegrationTest.php
that is not needed anymore, lets get rid of that too.
Both removed 👍🏼 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dinooo13 Thank you for looking into this, this is a big improvement! 👍
I've added a couple of questions / remarks, what do you think about this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're getting there! Spotted two minor oversights, otherwise LGTM! 👍
Fixed 👍🏼 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dinooo13 Thanks for the update, keep it up!
Found something to upgrade 🐳!
See https://github.com/reactphp/async
Ref: clue/reactphp-block#67, clue/reactphp-block#68, reactphp/http#464 and clue/reactphp-mq#34