Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests on PHP 8.3 and update test suite #85

Merged
merged 1 commit into from
Dec 19, 2023
Merged

Conversation

yadaiio
Copy link
Contributor

@yadaiio yadaiio commented Dec 19, 2023

This pull request builds on top of #80, #82, #83, #84 and #78.

References: reactphp/socket#300, clue/reactphp-zenity#63, clue/reactphp-csv#33, reactphp/promise-stream#39 and others.

After #83 was merged, I could go on with this pull request, thanks to @clue and @SimonFrings.

composer.json Outdated Show resolved Hide resolved
@yadaiio
Copy link
Contributor Author

yadaiio commented Dec 19, 2023

Okay, should be fixed right now. 👍

Copy link
Owner

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yadaiio Thanks for the update, changes LGTM! :shipit:

@clue clue merged commit 52ea569 into clue:1.x Dec 19, 2023
13 checks passed
@clue clue added this to the v1.5.0 milestone Dec 19, 2023
@yadaiio yadaiio mentioned this pull request Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants