Update CI setup to ensure 100% code coverage #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonFrings
approved these changes
May 17, 2022
This was referenced Oct 28, 2022
This was referenced Dec 1, 2022
This was referenced Apr 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This minimal PR updates the CI setup to ensure that PHPUnit always reports 100% code coverage. It does so by instructing PHPUnit to write an additional
clover.xmlfile which we then inspect to ensure all lines are covered.Accordingly, all future changes need to have matching tests. Any future changes/PRs that add code without adding matching tests will fail. This will hopefully help us steer new contributors towards better code quality. Additionally, this is also a nice starting point to add future mutation tests in a follow-up PR.
See also discussion on Twitter: https://twitter.com/another_clue/status/1526551148643098624
Builds on top of #27