Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation and examples #27

Merged
merged 2 commits into from
May 9, 2022
Merged

Improve documentation and examples #27

merged 2 commits into from
May 9, 2022

Conversation

SimonFrings
Copy link
Contributor

This PR improves some of the examples inside the README.md and the examples folder.

Builds on top of clue/reactphp-csv#30.
Refs clue/reactphp-socks#102.

Copy link
Owner

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimonFrings Thanks for the update, changes LGTM! :shipit:

(Unrelated HHVM build error is addressed in #28)

@clue clue added this to the v1.3.0 milestone May 9, 2022
@clue clue merged commit 5869138 into clue:main May 9, 2022
@yadaiio yadaiio mentioned this pull request Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants