Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify tests by supporting new Socket API #57

Merged
merged 1 commit into from
Aug 16, 2021
Merged

Conversation

SimonFrings
Copy link
Contributor

@SimonFrings SimonFrings commented Aug 16, 2021

This changeset simplifies tests by supporting the new Socket API with the new SocketServer.

// old (still supported)
$server = new React\Socket\Server(0);

// new
$server = new React\Socket\SocketServer('127.0.0.1:0');

Note that this doesn't affect the API of this package at all, but does use the improved API of the referenced Socket component. Existing code continues to work as is.

Together with #56, we can now fully rely on the default loop and no longer need to skip any arguments with null values.

Builds on top of reactphp/socket#264 and reactphp/socket#263

@clue clue added this to the v0.8.0 milestone Aug 16, 2021
Copy link
Owner

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimonFrings Thanks for the update, changes LGTM! :shipit:

@clue clue merged commit 929e081 into clue:master Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants