Add type definitions for all APIs and tests #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clue
force-pushed
the
types
branch
2 times, most recently
from
cc61f04 to
ff8eb66
Compare
clue
changed the title
|
Updated to only add types for public APIs and tests and not to internal properties (typed properties require PHP 7.4+, so this is left up to a future PR). This is now ready for review |
SimonFrings
approved these changes
May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset adds type definitions for all APIs and tests. This is a BC break in the sense that this was not enforced previously, but types are not changed otherwise.
Builds on top of #127 and #125