Skip to content

Support MONITOR command, forward "monitor" events #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 27, 2014
Merged

Support MONITOR command, forward "monitor" events #23

merged 2 commits into from
Aug 27, 2014

Conversation

clue
Copy link
Owner

@clue clue commented Aug 26, 2014

Refs #2.

@clue clue added this to the v0.5.0 milestone Aug 26, 2014
@clue clue mentioned this pull request Aug 27, 2014
Closed
@clue clue changed the title [WIP] Support MONITOR command, forward "monitor" events Support MONITOR command, forward "monitor" events Aug 27, 2014
@clue
Copy link
Owner Author

clue commented Aug 27, 2014

This is now considered completed.

  • Implementation
  • 100% test coverage
  • New example

Things not implemented (for now at least):

  • Parsing the StatusReply into timestamp, database, address and command
  • Issuing multiple "monitor" commands will not work (redis does not confirm any additional monitor commands, so who does this anyway?)

clue added a commit that referenced this pull request Aug 27, 2014
@clue
Merge pull request #23 from clue/monitor
9f10eb3 
Support MONITOR command, forward "monitor" events
@clue clue merged commit 9f10eb3 into master Aug 27, 2014
@clue clue deleted the monitor branch August 27, 2014 21:41
@clue clue mentioned this pull request Sep 19, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
new feature
Projects
None yet
Milestone
v0.5.0
Development

Successfully merging this pull request may close these issues.
1 participant
@clue