Avoid creation of dynamic property (PHP 8.2+)

clue · May 28, 2024 · e637704 · e637704
1 parent 039ce02
commit e637704
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 4 deletions.
diff --git a/phpunit.xml.dist b/phpunit.xml.dist
@@ -5,7 +5,8 @@
          xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/9.6/phpunit.xsd"
          bootstrap="vendor/autoload.php"
          cacheResult="false"
-         colors="true">
+         colors="true"
+         convertDeprecationsToExceptions="true">
     <testsuites>
         <testsuite name="Socks Test Suite">
             <directory>./tests/</directory>
@@ -16,4 +17,7 @@
             <directory>./src/</directory>
         </include>
     </coverage>
+    <php>
+        <ini name="error_reporting" value="-1" />
+    </php>
 </phpunit>
diff --git a/phpunit.xml.legacy b/phpunit.xml.legacy
@@ -15,4 +15,7 @@
             <directory>./src/</directory>
         </whitelist>
     </filter>
+    <php>
+        <ini name="error_reporting" value="-1" />
+    </php>
 </phpunit>
diff --git a/src/Server.php b/src/Server.php
@@ -387,9 +387,6 @@ public function connectTarget(ConnectionInterface $stream, array $target)
                 $that->endConnection($remote);
             });
 
-            // set bigger buffer size of 100k to improve performance
-            $stream->bufferSize = $remote->bufferSize = 100 * 1024 * 1024;
-
             return $remote;
         }, function(Exception $error) {
             // default to general/unknown error