Reject null byte in path to SQLite database file #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clue
reviewed
Sep 10, 2021
Owner
clue
left a comment
clue
left a comment
There was a problem hiding this comment.
@SimonFrings Thank you for looking into this!
I'm curious, what happens at the moment if we pass a null byte in the path (i.e. is this new logic needed)?
clue
added
help wanted
SimonFrings
force-pushed
the
path
branch
2 times, most recently
from
ceaabc2 to
827a9db
Compare
Contributor
Author
|
@clue I didn't noticed that there already was logic for older PHP versions to handle this scenario. |
clue
approved these changes
Sep 24, 2021
Owner
clue
left a comment
clue
left a comment
There was a problem hiding this comment.
@SimonFrings Thanks for the update, changes LGTM! 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When writing a null byte inside your file path to your SQLite database it's possible to receive an
TypeError(for PHP >= 7) in return.For older PHP versions we're already handling the thrown
Exception.