Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support running from PHAR #55

Merged
merged 3 commits into from
Jan 11, 2022
Merged

Support running from PHAR #55

merged 3 commits into from
Jan 11, 2022

Conversation

clue
Copy link
Owner

@clue clue commented Jan 11, 2022

This changeset adds support for running from PHARs. This works out of the box without any special configuration by running the SQLite worker like this internally:

$ php -r 'require("phar:///home/alice/Desktop/acme.phar/vendor/clue/reactphp-sqlite/res/sqlite-worker.php");'

The updated test suite confirms this works across all supported platforms, including Windows (which requires some special care). Windows tests on PHP < 7.3 may currently be skipped because building the PHAR fails due to clue/phar-composer#116, but execution should work just fine in either case.

Resolves / closes #5
Builds on top of #50, #45, clue/phar-composer#123 and others

@clue clue added the new feature New feature or request label Jan 11, 2022
@clue clue added this to the v1.4.0 milestone Jan 11, 2022
@clue clue requested a review from SimonFrings January 11, 2022 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support running from PHAR
2 participants