Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows support #12

Open
clue opened this issue Apr 30, 2019 · 2 comments
Open

Windows support #12

clue opened this issue Apr 30, 2019 · 2 comments
Labels
help wanted Extra attention is needed new feature New feature or request

Comments

@clue
Copy link
Owner

clue commented Apr 30, 2019

No description provided.

@clue clue added new feature New feature or request help wanted Extra attention is needed labels Apr 30, 2019
@clue
Copy link
Owner Author

clue commented May 1, 2019

The ssh binary is available on recent Windows 10 installations by default, so this shouldn't be too much work.

We have to work around Windows' process I/O pipes (https://github.com/reactphp/child-process#windows-compatibility), e.g. by using socket I/O redirection instead (clue/reactphp-sqlite#13). This should at least support the SOCKS connector, the STDIO/process connector would likely not support this.

Additionally, it looks like sshpass (used for password authentication) is not available on Windows. This means automatic login may not be possible. This may or may not be a problem, but at least pubkey based authentication should work.

@clue
Copy link
Owner Author

clue commented Apr 24, 2022

Small update: Windows support is now much more reasonable as of PHP 8+ because PHP now supports socket pair descriptors (reactphp/child-process#85).

On top of of, we may also be able to avoid the dependency on the sshpass binary for password authentication by employing the SSH_ASKPASS environment variable as discussed in #33.

I'm not currently working on this myself, but figured it makes sense to post here anyway. If you need this for a commercial project and you want to help sponsor this feature, feel free to reach out and I'm happy to take a look. PRs are also welcome! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed new feature New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant