Fix and simplify restoring TTY mode when ext-readline is not in use #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clue
commented
Aug 31, 2018
| // Reset stty so it behaves normally again | ||
| shell_exec(sprintf('stty %s', $this->originalTtyMode)); | ||
| shell_exec('stty ' . escapeshellarg($this->originalTtyMode)); |
There was a problem hiding this comment.
This simple change introduces a subtle bug fixed in #78. The originalTtyMode contains a trailing newline, passing this to escapeshellarg() means that this will now be passed as part of the argument to the stty bin which rejects this format because it does not expect a trailing newline.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on top of #73