Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GitHub actions for continuous integration (CI) #97

Merged
merged 3 commits into from
Jun 11, 2021
Merged

Conversation

SimonFrings
Copy link
Contributor

@SimonFrings SimonFrings commented Jun 11, 2021

Bye bye Travis CI, you've served us well.

Some of the functional tests only fail when executed by GitHub CI. The reason why GitHub actions shows this behavior is unclear at this point. It worked fine with Travis and still works fine when executed local on the command line. That's why I chose to skip the tests for now. If someones out there who ran into the same problem or even better, knows the answer, please let me know :).

This pull request builds on top of #94 and reactphp/reactphp#442.

@clue
Copy link
Owner

clue commented Jun 11, 2021

Some of the functional tests only fail when executed by GitHub CI. The reason why GitHub actions shows this behavior is unclear at this point. It worked fine with Travis and still works fine when executed local on the command line. That's why I chose to skip the tests for now. If someones out there who ran into the same problem or even better, knows the answer, please let me know :).

Interesting one, looks indeed strange. It looks like this affects the tests introduced via #57 only, but I agree they don't provide a lot of value for real-world use cases. Test coverage is still reported as 100% for PHP 7, so let's get this in as-is, we can still reenable these tests again in the future 👍

@clue clue merged commit 89d0dbb into clue:master Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants