Merge pull request #67 from clue-labs/php8.1

Forward compatibility with PHP 8.1 release
clue · Apr 4, 2022 · 5ed4f15 · 5ed4f15
2 parents 5f84e61 + 1db580b
commit 5ed4f15
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 7 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -13,6 +13,7 @@ jobs:
           - ubuntu-latest
           - windows-latest
         php:
+          - 8.1
           - 8.0
           - 7.4
           - 7.3

diff --git a/phpunit.xml.dist b/phpunit.xml.dist
@@ -4,8 +4,9 @@
 <phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" 
          xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/9.3/phpunit.xsd"
          bootstrap="vendor/autoload.php"
+         cacheResult="false"
          colors="true"
-         cacheResult="false">
+         convertDeprecationsToExceptions="true">
     <testsuites>
         <testsuite name="Socket Test Suite">
             <directory>./tests/</directory>

diff --git a/tests/SocketTest.php b/tests/SocketTest.php
@@ -83,8 +83,6 @@ public function testConnectAsyncGoogle()
 
         $this->assertInstanceOf('Socket\Raw\Socket', $socket);
 
-        $this->assertSame($socket, $socket->bind('0:0'));
-
         $this->assertSame($socket, $socket->setBlocking(false));
 
         try {
@@ -225,10 +223,6 @@ public function testServerNonBlocking()
      */
     public function testServerNonBlockingAcceptNobody(Socket $server)
     {
-        if (PHP_VERSION_ID >= 80000) {
-            $this->markTestIncomplete('Causes SEGFAULTs on PHP 8');
-        }
-
         try {
             $server->accept();
             $this->fail('accept() MUST throw an exception');
-Original file line number
+Diff line change
@@ Expand Up / @@ -13,6 +13,7 @@ jobs: @@
               - ubuntu-latest
               - windows-latest
             php:
+              - 8.1
               - 8.0
               - 7.4
               - 7.3
@@ Expand Down @@