Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support PHP 8, use Socket object instead of socket resource #61

Merged
merged 1 commit into from
Nov 27, 2020

Conversation

clue
Copy link
Owner

@clue clue commented Nov 27, 2020

This changeset adds support for PHP 8 (released just yesterday). PHP 8 uses Socket objects instead of socket resource and has some stricter error reporting semantics, it otherwise works as-is.

I've also had to skip one test which currently causes a SEGFAULT on PHP 8, this should probably be reported upstream:

class Test extends PHPUnit\Framework\TestCase
{
    public function testA()
    {
        $socket = socket_create_listen(0);
        socket_set_nonblock($socket);
        $ret = socket_accept($socket);

        $this->assertFalse($ret);
    }
}

Builds on top of #59 and #60

@clue clue added this to the v1.5.0 milestone Nov 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants