controlplane/peer/client: Issue requests in parallel #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orozery
force-pushed
the
peer-multiple-gateways
branch
from
bd467d8 to
78ad44c
Compare
kfirtoledo
reviewed
Apr 15, 2024
| func (c *Client) getResponse( | ||
| getRespFunc func(client *jsonapi.Client) (*jsonapi.Response, error), | ||
| ) (*jsonapi.Response, error) { | ||
| if len(c.clients) == 1 { |
There was a problem hiding this comment.
Why do you need this case and can't do iteration on 1 client?
There was a problem hiding this comment.
This is the common case, and the purpose is to make it more simple since you don't need go-routines and the multi-threaded syncing in this case.
kfirtoledo
approved these changes
Apr 15, 2024
kfirtoledo
approved these changes
Apr 15, 2024
| body, err := json.Marshal(req) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("unable to serialize authorization request: %w", err) | ||
| func (c *Client) getResponse( |
There was a problem hiding this comment.
Can you write a comment for the function, what it returns in case of multiple gateways (in the function description or near the code)
This commit changes the client to issue requests in parallel for peers who have multiple gateways. Signed-off-by: Or Ozeri <oro@il.ibm.com>
orozery
force-pushed
the
peer-multiple-gateways
branch
from
78ad44c to
0c1d041
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the client to issue requests in parallel for peers who have multiple gateways.