Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.github/workflows: Add release support to linux/arm64 platform #541

Merged
merged 2 commits into from
Apr 30, 2024
Merged

.github/workflows: Add release support to linux/arm64 platform #541

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fcb9d27
.github/workflows: Add release support to linux/arm64 platform
kfirtoledo Apr 25, 2024
42c5085
Merge branch 'main' into release
kfirtoledo Apr 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:
run: make push-image IMAGE_VERSION=${{ github.ref_name }}
- name: Build and compress binaries
run: |
for pair in "linux:amd64" "darwin:amd64" "darwin:arm64"; do
for pair in "linux:amd64" "linux:arm64" "darwin:amd64" "darwin:arm64"; do
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can have two for loops ( {linux,darwin} x {amd64,arm64} ) instead of having to parse os:arch in the next line

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now, I prefer to leave it like this, for case we want support arch only in one os

IFS=':' read -r os arch <<< "$pair"
GOOS="$os" GOARCH="$arch" CGO_ENABLED=0 make cli-build BIN_DIR="$os"
tar -czvf "clusterlink-$os-$arch.tar.gz" --transform "s/$os/clusterlink/" ./"$os"
Expand Down
Loading