remove controlplane CRUD mode #597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orozery
requested review from
elevran,
michalmalka,
zivnevo and
kfirtoledo
as code owners
orozery
force-pushed
the
remove-crud-mode
branch
3 times, most recently
from
f6a22ca to
91b5f2e
Compare
elevran
approved these changes
May 21, 2024
| # 1) cluster1- contain gw, gwctl,product and details microservices (bookinfo services) | ||
| # 2) cluster2- contain gw, gwctl, review-v2 and rating microservices (bookinfo services) | ||
| # 3) cluster3- contain gw, gwctl, review-v3 and rating microservices (bookinfo services) | ||
| # 1) cluster1- contain gw, product and details microservices (bookinfo services) |
There was a problem hiding this comment.
nit: unrelated to this change but we should probably be consistent in using lower case or upper case gw/GW in comments and elsewhere (e.g., here in python vs demos/speedtest/kind/README.md)
praveingk
approved these changes
May 21, 2024
kfirtoledo
approved these changes
May 21, 2024
@praveingk release v0.2.1 is tagged and includes the code before the change. A tag can always be converted to a branch. |
This commit removes the legacy CRUD-based controlplane (i.e. the non-CRD mode). Signed-off-by: Or Ozeri <oro@il.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the legacy CRUD-based controlplane (i.e. the non-CRD mode).