Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send attributes of source workload to remote peer #609

Merged
merged 2 commits into from
May 26, 2024
Merged

Send attributes of source workload to remote peer #609

merged 2 commits into from
May 26, 2024

Conversation

zivnevo
Copy link
Collaborator

@zivnevo zivnevo commented May 23, 2024

Fixes #293

@zivnevo
Send attributes of source workload to remote peer
a33d726 
Signed-off-by: Ziv Nevo <nevo@il.ibm.com>
@zivnevo zivnevo added the policies Issues related to policies and policy engine label May 23, 2024
@elevran
Copy link
Collaborator

elevran commented May 24, 2024

where does the collection of attributes done?

@zivnevo
Copy link
Collaborator Author

zivnevo commented May 26, 2024

where does the collection of attributes done?

Currently it is done on the peer at the client-workload side when authorizing the egress request (Manager::authorizeEgress).
We may decide to move it to another function/struct when there is enough "beef" around it.
The idea behind this PR is that both peers will use exactly the same set of attributes for the source workload.

@orozery orozery closed this May 26, 2024
@orozery orozery reopened this May 26, 2024
@orozery
Copy link
Collaborator

orozery commented May 26, 2024

Sorry, closed by mistake. Re-opened.

@elevran
Copy link
Collaborator

elevran commented May 26, 2024

so this just makes sure we send/use the attributes and does not affect which are collect, right?

@zivnevo
Copy link
Collaborator Author

zivnevo commented May 26, 2024

so this just makes sure we send/use the attributes and does not affect which are collect, right?

right

@zivnevo zivnevo merged commit 1aa5bca into clusterlink-net:main May 26, 2024
9 checks passed
@zivnevo zivnevo deleted the send-src-attrs branch May 26, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elevran elevran elevran approved these changes

@kfirtoledo kfirtoledo Awaiting requested review from kfirtoledo kfirtoledo is a code owner

@orozery orozery Awaiting requested review from orozery

Assignees
No one assigned
Labels
policies Issues related to policies and policy engine size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sending attributes of the client workload in a connection request
3 participants
@zivnevo @elevran @orozery