use standalone tcp for health checker #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @Iceber, DetailsInstructions for interacting with me using comments are available here. |
|
@cleverhu PTAL |
Iceber
force-pushed
the
health_checker_with_standalone_tcp
branch
from
963b109 to
5106527
Compare
Iceber
changed the title
Iceber
force-pushed
the
health_checker_with_standalone_tcp
branch
from
5106527 to
e37da13
Compare
Signed-off-by: Iceber Gu <wei.cai-nat@daocloud.io>
Iceber
force-pushed
the
health_checker_with_standalone_tcp
branch
from
e37da13 to
d08c4b3
Compare
|
/LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Iceber Gu wei.cai-nat@daocloud.io
What type of PR is this?
/kind feature
What this PR does / why we need it:
When client-go creates any number of Clients with the same configuration, such as certificates, it reuses the same TCP connection.
https://github.com/kubernetes/kubernetes/blob/3f823c0daa002158b12bfb2d53bcfe433516659d/staging/src/k8s.io/client-go/transport/transport.go#L54
This results in the cluster health check interface using the same TCP connection as the resource synchronized informer, which may cause TCP blocking and increased health check latency if a large number of informers are started for the first time.
We add a feature gate -
HealthCheckerWithStandaloneTCPto allow users to use a standalone tcp for health checksWhich issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: