add memory filter lable select #526
Conversation
|
Hi @lengrongfu, DetailsInstructions for interacting with me using comments are available here. |
lengrongfu
force-pushed
the
feat/add-api-resources-api
branch
2 times, most recently
from
ccd614b to
bdbff83
Compare
|
/cc @xyz2277 |
|
@xyz2277 TBR. |
|
@lengrongfu, thanks for your contribution. It's ok for list, can you add this feature to the watch too? |
|
Can I submit a new pr to add watch ？ |
lengrongfu
force-pushed
the
feat/add-api-resources-api
branch
2 times, most recently
from
d4bfb0b to
b2f733b
Compare
| // filterLabelSelector returns true if the given label selector matches the given label set. else false. | ||
| func filterLabelSelector(labelSelector labels.Selector, label labels.Set) bool { | ||
| if labelSelector != nil && label != nil && !labelSelector.Matches(label) { | ||
| return true |
There was a problem hiding this comment.
should be true if the label is nil?
There was a problem hiding this comment.
return true is filter current item， when label is nil should return false.
Signed-off-by: lengrongfu <1275177125@qq.com>
lengrongfu
force-pushed
the
feat/add-api-resources-api
branch
from
b2f733b to
77d09f2
Compare
ok, don't forget it~ |
|
/lgtm |
|
@lengrongfu Thanks for your contribution |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes # #380
Special notes for your reviewer:
Does this PR introduce a user-facing change?: