Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support openapi v2 for compatibility lower kubernete versions #588

Merged
merged 1 commit into from
Nov 12, 2023

Conversation

huiwq1990
Copy link
Contributor

What type of PR is this?

What this PR does / why we need it:

If we want to run clusterpedia in low kubernete version , the kubernete apiserver will output error logs.

E1109 11:09:21.665110       1 controller.go:116] loading OpenAPI spec for "v1beta1.clusterpedia.io" failed with: OpenAPI spec does not exist
I1109 11:09:21.665131       1 controller.go:129] OpenAPI AggregationController: action for item v1beta1.clusterpedia.io: Rate Limited Requeue.  

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Signed-off-by: huiwq1990 <huiwq1990@163.com>
@clusterpedia-bot
Copy link

Hi @huiwq1990,
Thanks for your pull request!
If the PR is ready, use the /auto-cc command to assign Reviewer to Review.
We will review it shortly.

Details

Instructions for interacting with me using comments are available here.
If you have questions or suggestions related to my behavior, please file an issue against the gh-ci-bot repository.

@Iceber
Copy link
Member

Iceber commented Nov 9, 2023

Thanks @huiwq1990, this looks like a very meaningful pr, I'll verify it!

Copy link
Member

@Iceber Iceber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks

@Iceber Iceber merged commit 41975c5 into clusterpedia-io:main Nov 12, 2023
7 checks passed
@huiwq1990 huiwq1990 deleted the feat-openapiv2 branch November 13, 2023 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants