Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update the created_at field when updating resource #629

Merged
merged 1 commit into from
Dec 26, 2023

Conversation

flpanbin
Copy link
Contributor

What type of PR is this?

/kind bug

What this PR does / why we need it:
When clustersynchro-manager updating resource, the created_at field would not be updated, which may lead to the created_at of the resource inconsistent with the creationTimestamp of the object.

image

Which issue(s) this PR fixes:
Fixes #626

Special notes for your reviewer:

test results:

image

the created_at for elastic-operator-0 and amamba-argocd-application-controller-0 has been updated:
image

Does this PR introduce a user-facing change?:


Signed-off-by: bin <bin.pan@daocloud.io>
@clusterpedia-bot
Copy link

Hi @flpanbin,
Thanks for your pull request!
If the PR is ready, use the /auto-cc command to assign Reviewer to Review.
We will review it shortly.

Details

Instructions for interacting with me using comments are available here.
If you have questions or suggestions related to my behavior, please file an issue against the gh-ci-bot repository.

@clusterpedia-bot clusterpedia-bot added the kind/bug Something isn't working label Dec 25, 2023
Copy link
Member

@Iceber Iceber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, This is a very important fix, Thanks!

@Iceber Iceber merged commit 5146bdb into clusterpedia-io:main Dec 26, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

the created_at in the resources table may inconsistent with the creationTimestamp of the resource object
3 participants