This repository has been archived by the owner on Oct 19, 2021. It is now read-only.
Add prefer_logical_operator rule #545
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
berrberr
changed the title
| lintToken: (token, tokenApi) -> | ||
| # console.log "lintToken :: ", token | ||
| config = tokenApi.config[@rule.name] | ||
| level = config.level |
There was a problem hiding this comment.
I don't think you need to do this, the linter already handles the error level if there is an error thrown.
There was a problem hiding this comment.
ahh it looks like you took this from prefer_english_operator yeah this probably isn't needed.
|
Looks good, if you could delete line 16-18 in the rules, and just have it return Sorry for the delay. |
|
Thanks for taking a look! Added those changes in. |
|
@clutchski bump 🔫 |
|
hey folks, i don't really work on this project anymore. feel free to reach
out to shaun or fork the project.
https://github.com/clutchski/coffeelint#team
…On Thu, Jan 26, 2017 at 2:43 AM, Ivan Verevkin ***@***.***> wrote:
@clutchski <https://github.com/clutchski> bump 🔫
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#545 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAFpQpNNTdruMr7AkQfeDZ0OAJPWNSB9ks5rWE6VgaJpZM4HLZJF>
.
|
|
Further development on coffeelint will be on coffeelint/coffeelint and will be released as @coffeelint/cli. This PR will be tracked at coffeelint/coffeelint#13 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rule is essentially the inverse of
prefer_english_operator.