-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add paymaster gossip SQL #1103
base: master
Are you sure you want to change the base?
Add paymaster gossip SQL #1103
Conversation
I'd still pretty much like having "spawn" data for these npcs, be it part of an "arena tournament or ptr", so we can actually actively utilize these scripts.
|
There are technical limitations on the 2.4.3 Client that prevent most of the NPCs from being effectively used when filled out with accurate data (they can crash the client because the number of items the vendors sell is larger than 15 pages). KW fixed it so the client no longer crashes, but now every item past page 15 is lost to the ether. The only real solution to make effective use of these NPCs is to make them different from the reference material (by duplicating them and splitting the vendor slots between them), which is not compatible with 1) the pedestals which summon the vendors and 2) the spawn data. I'm implementing these like this because like this they are accurate to the source, but they can only be used with the intention of supporting the effort of whoever is testing the server. |
Well maybe, now after the split of vendor lists, we should "list" the other half of items in a second npc that shares the same spell in a second spell effect[x] so this all actually does something... if it's wanted we can easily figure out a dummy entry that is unused so it can be utilized for this purpose, atleast in tbc, maybe wotlk. |
The spawn data would still be incorrect, as the spawn data does not consider 2 NPCs being used. I can look into it, but I don't have accurate spawn data for these NPCs aside from Video evidence, which isn't particularly accurate. If someone does have the data I can make a separate PR. |
Nobody has spawn data of these pedestals? Seems strange at this point... |
I don't, at least. Can't speak for others. The zip contains the duplicated vendor NPCs and their respective |
ac69918
to
6545b94
Compare
2bb4f2e
to
189a5d9
Compare
6f6379f
to
55641c8
Compare
This PR adds the Gossip Menu and Broadcast Text conversion for this PR:
cmangos/mangos-tbc#536