Remove pipenv dependency

pipenv is really slow and sometimes it hangs for a really long time. Perhaps because I'm using a private PyPi instance that makes it worse, but that works fine with plain pip. This seems to be a common problem - see and the several other linked issues there: pypa/pipenv#3827 So far, this is just the result of grep/search/replace. Haven't tested this at all and there's more work to do. Just want to start by getting some feedback if this is going to be something that everyone is OK with. Closes hashicorp#324
cmclaughlin · Aug 19, 2020 · 8acb40c · 8acb40c
1 parent 06cf128
commit 8acb40c
Show file tree

Hide file tree

Showing 29 changed files with 37 additions and 369 deletions.
diff --git a/Dockerfile b/Dockerfile
@@ -1,6 +1,6 @@
 FROM jsii/superchain
 
-RUN yum install -y unzip && curl https://raw.githubusercontent.com/pypa/pipenv/master/get-pipenv.py | python
+RUN yum install -y unzip
 
 ENV DEFAULT_TERRAFORM_VERSION=0.13.0
 

diff --git a/docs/getting-started/python.md b/docs/getting-started/python.md
@@ -5,7 +5,6 @@
 - [Terraform](https://www.terraform.io/downloads.html) >= v0.12
 - [Node.js](https://nodejs.org) >= v12.16
 - [Python](https://www.python.org/downloads/) >= v3.7
-- [Pipenv](https://pipenv.pypa.io/en/latest/install/#installing-pipenv/)
 
 ### Install CDK for Terraform CLI
 

diff --git a/examples/python/aws/Pipfile b/examples/python/aws/Pipfile
diff --git a/examples/python/aws/Pipfile.lock b/examples/python/aws/Pipfile.lock
diff --git a/examples/python/aws/README.md b/examples/python/aws/README.md
@@ -4,17 +4,10 @@ A CDK for Terraform application in Python.
 
 ## Usage
 
-Install Pipenv using Homebrew by running:
-
-```bash
-$ brew install pipenv
-```
-You can install Pipenv by visiting the [website](https://pipenv.pypa.io/en/latest/).
-
 Install project dependencies
 
 ```shell
-pipenv install
+pip3 install -r requirements.txt
 ```
 
 Generate CDK for Terraform constructs for Terraform provides and modules used in the project.

diff --git a/examples/python/aws/cdktf.json b/examples/python/aws/cdktf.json
@@ -1,7 +1,7 @@
 {
  "language": "python",
- "app": "pipenv run ./main.py",
+ "app": "python3 main.py",
  "terraformProviders": ["aws@~> 2.0"],
  "terraformModules": ["terraform-aws-modules/vpc/aws"],
  "codeMakerOutput": "imports"
-}
+}
diff --git a/examples/python/aws/requirements.txt b/examples/python/aws/requirements.txt
@@ -0,0 +1 @@
+./../../../dist/python/cdktf-0.0.0-py3-none-any.whl
diff --git a/examples/python/docker/Pipfile b/examples/python/docker/Pipfile
diff --git a/examples/python/docker/Pipfile.lock b/examples/python/docker/Pipfile.lock
diff --git a/examples/python/docker/README.md b/examples/python/docker/README.md
@@ -3,17 +3,10 @@
 
 ## Usage
 
-Install Pipenv using Homebrew by running:
-
-```bash
-$ brew install pipenv
-```
-You can install Pipenv by visiting the [website](https://pipenv.pypa.io/en/latest/).
-
 Install project dependencies
 
 ```shell
-pipenv install
+pip3 install -r requirements.txt
 ```
 
 Generate CDK for Terraform constructs for Terraform provides and modules used in the project.

diff --git a/examples/python/docker/cdktf.json b/examples/python/docker/cdktf.json
@@ -1,8 +1,8 @@
 {
  "language": "python",
- "app": "pipenv run ./main.py",
+ "app": "python3 main.py",
  "terraformProviders": [
  "terraform-providers/docker@~> 2.0"
  ],
  "codeMakerOutput": "imports"
-}
+}
diff --git a/examples/python/docker/help b/examples/python/docker/help
@@ -5,11 +5,11 @@
  cat help Prints this message
 
  Compile:
- pipenv run ./main.py Compile and run the python code.
+ python main.py  Compile and run the python code.
 
  Synthesize:
  cdktf synth Synthesize Terraform resources to cdktf.out/
- 
+
  Diff:
  cdktf diff Perform a diff (terraform plan) for the given stack
 

diff --git a/examples/python/docker/requirements.txt b/examples/python/docker/requirements.txt
@@ -0,0 +1 @@
+./../../../dist/python/cdktf-0.0.0-py3-none-any.whl
diff --git a/examples/python/kubernetes/Pipfile b/examples/python/kubernetes/Pipfile