Fix git branch colouring #1011
Merged
Fix git branch colouring #1011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM! A |
Colouring fixed when there are some changes in a branch
ghost
force-pushed
the
git_branch_colouring
branch
from
551cff1
to
9c0ad9f
Compare
|
I did rebase on my |
|
I must say I don't like this because even untracked files are now triggering color change 👎 |
|
Can be easily changed, to exclude untracked files. The question is what is the correct behaviour here. Not sure who decides here... |
|
Hrm, green for clean, yellow for untracked files, red for untracked files and changes? |
|
Sounds like a plan, but I would leave the default font colour for clean repo. |
|
Yeah probably more sane |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More elegant way of detecting changes in git repo.
Second pull request to a proper branch per @Stanzilla request.