Fix bash login when $CMDER_ROOT has spaces #1078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
E.g., if ${CMDER_ROOT} is /c/Users/Foo Bar/cmder,
the following errors will occur:
bash: pushd: /c/Users/Foo: No such file or directory
bash: [: /c/Users/Foo: binary operator expected
bash: /c/Users/Foo: No such file or directory
Inspecting the script uncovers similar problems elsewhere not encountered in my initial testing. They are fixed accordingly.
|
FYI, the original errors I encountered: |
|
No, please change to master. @daxgames are you ok with this? I mean it's sort of a trivial change (at least the first commit) but you wrote the code in the first place. Thanks for the PR, orionlee! |
|
@Stanzilla I agree 2nd commit is slightly tricky (double quotes cannot handle having spaces along with a wild card), and is more prone to regress. |
|
Looks good to me. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The patch fixed the errors when using bash and cmder is installed under a directory with spaces in the path, e.g.
c:\Users\Foo Bar\cmder. Please review. Thanks.The first commit fixed errors I encountered (in v1.3.0), while the second commit fixed similar issues.
Note: The development branch (the base) is behind master, in fact, pre v1.3.0. Should I stick with merging to it?