Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting the build script to a working state #157

Merged
merged 2 commits into from
Feb 26, 2014

Conversation

Jackbennett
Copy link
Contributor

I didn't mean to re-write as much as I did. It was mostly working as it was but I kept on going to handle some edge cases.

I think because I used invoke-webrequest this is not PSv3.0 only. I'll come back to looking at this to use the .NET Webclient. I was trying to get it to run in parallel.

If you run

help .\build.ps1 -full

in powershell you'll see why the top comment is so funky and why using types helps.

Could could still do with handling being executed outside the the cmder/scripts directory. And a swath of other things.

incase url's that don't put the file in the url.
working script will;
Remove existing folders named in the sources
Download the packages listed in sources.json
Extracts the above packages
deletes the downloaded package
@Jackbennett Jackbennett mentioned this pull request Feb 26, 2014
6 tasks
@@ -12,6 +12,7 @@
{
"name": "conemu-maximus5",
"version": "140124",
"url": "http://www.fosshub.com/download/ConEmuPack.140124.7z"
"url": "http://conemu.codeplex.com/downloads/get/782952",
"package": "ConEmuPack.140124.7z"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we somehow avoid this? The link I used was nice, but as you changed it I guess b/c it does not allow hot linking.
Could we possibly just name the download the archive, name it conemu-maximus5.zip (or just conemu-maximus5). I am pretty sure 7z only cares about archive metadata/headers. That way we can avoid caring about the extension and filename and this field will be unnecessary.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah without hotlinking it's fairly useless.
You can name that package key whatever you want if you set it, otherwise the script pulls the name and url extension together sets that as the package, and carries on.

@samvasko
Copy link
Contributor

Very good work. I did not know that about the majority of the stuff :-D so good thing you checked it out.

samvasko added a commit that referenced this pull request Feb 26, 2014
Getting the build script to a working state
@samvasko samvasko merged commit 6d0d93e into cmderdev:scripts Feb 26, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants