-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-factor the build script to distinguish each step #2758
Conversation
@daxgames Please have a look, thanks! 📦 Download from GitHub Actions: https://github.com/cmderdev/cmder/actions/runs/3259741744 |
@DRSDavidSoft are you adding Github |
That's also a good idea, but those functions are for the GitHub Actions / CI. I think |
I could see adding |
Odd it downloads from Github actions as |
@daxgames Sad to say, this is a known limitation by the authors (https://github.com/actions/upload-artifact#zipped-artifact-downloads). I haven't found anything yet to overcome this |
This PR addresses #2757
Description
-noVendor
switch to bypass downloading vendor packagesmsbuild.exe
in path when the-Compile
switch is used👉 Note: The order of build has changed. Previously, the vendor packages were downloaded first, and then the launcher was subsequently built.
Since the launcher doesn't depend on vendored packages, and it might fail first, this PR moves the build step before downloading files, so if it fails the vendored files aren't downloaded and discarded.