Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user startup file for powershell #666

Merged
merged 1 commit into from
Oct 14, 2015
Merged

Add user startup file for powershell #666

merged 1 commit into from
Oct 14, 2015

Conversation

Pireax
Copy link
Contributor

@Pireax Pireax commented Oct 14, 2015

The cmd version has a customizable file but powershell was missing one.

Stanzilla added a commit that referenced this pull request Oct 14, 2015
Add user startup file for powershell
@Stanzilla Stanzilla merged commit 215ba57 into cmderdev:development Oct 14, 2015
@Pireax Pireax deleted the posh-user-script branch October 14, 2015 17:26
@jankatins
Copy link
Contributor

vendor\init.bat got a comment at the top of the file not to change it. Maybe vendor/profile.ps1 should also get such a comment?

@Stanzilla
Copy link
Member

@JanSchulz agree, done.

@pavelkouril
Copy link

Why not use the user profile though? Maybe @Jackbennett could say which option would be better?

@Stanzilla
Copy link
Member

Related to #505 (comment) then. Depends on how you look at being portable, I guess.

@Pireax
Copy link
Contributor Author

Pireax commented Oct 14, 2015

It isn't a question of if it's better to use a user profile or a portable profile file, with the portable profile file the option to use the user profile remains. This way we have both. The user can choose to run the user profile from the portable script or omit the -NoProfile launch option.

@Stanzilla
Copy link
Member

Yup, my answer was more aimed at pavel, and the defaults we set.

@Pireax
Copy link
Contributor Author

Pireax commented Oct 14, 2015

Mine too ;)

@Jackbennett
Copy link
Contributor

I think using a cmder profile would be good. Anyone who wants to pull in their own PS Profile should know they can just dot source it . $profile.currentuserAllHosts

Although if you don't know powershell you won't have your own customized profile anyway.. hmm. Should cmder be it's own self contained little terminal or be a great baseline to add your own stuff onto that also happens to run portably.

Tough that it's not really I code problem. I vote use a cmder profile but keep in mind it's not a mandatory one. That's consistent with how cmd behaves and also doesn't have to worry about clobbering someone's main profile. At least until someone complains with a better/more informed use case.

@pavelkouril
Copy link

Yeah, true, you just can launch the $profile from this user startup file. Don't know why this didn't occur to me. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants