Added check for git install path in init.bat. #734
Conversation
….bat. Installing from https://git-scm.com/download/win seems to put git in this directory.
Added check for git install path in init.bat.
|
Looks good to me, thanks! |
|
It turns out that the root cause of the issue I had deals with a bug in ConEmuHk DLL truncating stdout to 4096 characters...not sure how my change fixed it at all (it was only temporary). See bower/bower#852 (comment). I'm going to check out the ConEmu project to see if they already have a fix. That said, how do we go about adding ConEmu fixes into cmder? |
|
As an FYI, I copied the latest stable versions of ConEmuHk.dll and ConEmuHk64.dll into the appropriate folder within cmder\vendor and it managed to resolve the issue. I've got no idea if it's going to create other issues, though. Should I open an issue regarding this? |
|
We try to keep up to date, especially with ConEmu as it has a very rapid release cycle. I can see we're a version behind already in the development branch. I've had an idea for a dependency updater, but I haven't started any work on it. |
|
I've created #739 to track this issue :-) |
Added check for %USERPROFILE%\AppData\Local\Programs\Git path in init.bat. Installing from https://git-scm.com/download/win seems to put git in this directory.
Long story short, I was having issues doing npm installs pointing to cmder's packaged version of git-for-windows, but the version from https://git-scm.com/download/win worked just fine. This change defaults to using an installed version of git outside of cmder's packaged version.