Fix the git command to obtain the dirty state of the repository

[sveggiani]

Fixes #928

[luisrudge]

I can confirm this is now working:

[Stanzilla]

We had a few problems with os.execute which is why we switched away from it #749 #692

Does this help you maybe? #809 (comment) Maybe removing 2>nulis already good enough?

[sveggiani]

@Stanzilla nope, it doesn't work. I'll try to come up with another solution.

[vBm]

@Stanzilla I've also tried what's suggested in 809 but doesn't help either.
However, this patch makes it work again.

[Stanzilla]

567889e found it, paging @JanSchulz

[jankatins]

Unfortunately, I only send the patch, not found the cause: @vvartivarian-nbcu suggested the particular fix: #749 (comment)

[jankatins]

But reading this: http://www.lua.org/manual/5.1/manual.html#pdf-io.popen it looks like the solution could never work: t returns a handle and not the exit code:

io.popen (prog [, mode])
Starts program prog in a separated process and returns a file handle that you can use to read data from this program (if mode is "r", the default) or to write data to this program (if mode is "w").
This function is system dependent and is not available on all platforms.

[jankatins]

See also http://stackoverflow.com/questions/7607384/getting-return-status-and-program-output

this works:

---
 -- Get the status of working dir
 -- @return {bool}
---
function get_git_status()
    local file = io.popen("git diff --quiet --ignore-submodules HEAD 2>nul")
    -- This will get a table with some return stuff
    -- rc[3] will be the signal, 0 or 1
    local rc = {file:close()}
    return rc[3] == 0 
end

-> Will send a PR

[jankatins]

See #974 for the PR, please test... :-)

[sveggiani]

Closing this in favor of the more appropiate fix in #974