fix some issues found by codacy

cmeissner · Oct 20, 2023 · dd9b5d5 · dd9b5d5
1 parent b957cbd
commit dd9b5d5
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/tests/docker/setup_database.sh b/tests/docker/setup_database.sh
@@ -7,17 +7,17 @@ function info() {
     echo "${@}" >&10
 }
 
-MYSQL_PING='mysqladmin ping -h ${DB_HOST:-127.0.0.1} -P ${DB_PORT:-3306} -u ${MYSQL_ROOT_USER:-root} -p${MYSQL_ROOT_PASSWORD:-rootpw}'
+MYSQL_PING="mysqladmin ping -h ${DB_HOST:-127.0.0.1} -P ${DB_PORT:-3306} -u ${MYSQL_ROOT_USER:-root} -p${MYSQL_ROOT_PASSWORD:-rootpw}"
 
 if grep -q podman <<< $(docker --version 2> /dev/null) ; then
   info "Podman is installed"
   DOCKER_CMD=$(which podman)
 fi
 
-if ${DOCKER_CMD} ps | grep -q docker_phpipam_1 && ! eval ${MYSQL_PING} ; then
+if "${DOCKER_CMD}" ps | grep -q docker_phpipam_1 && ! eval "${MYSQL_PING}" ; then
 
     info -n "Waiting for database connection "
-    while ! eval ${MYSQL_PING} ; do
+    while ! eval "${MYSQL_PING}" ; do
         info -n "."
         sleep 1
     done