Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug fix "[latexindent.exe] -GCString switch cannot run normally" #532

Merged
merged 2 commits into from
Mar 28, 2024

Conversation

saxyx
Copy link
Contributor

@saxyx saxyx commented Mar 25, 2024

what is this pull request about?

bug fix "[latexindent.exe] -GCString switch cannot run normally"

does this relate to an existing issue?

#531

does this change any existing behaviour?

no

@saxyx saxyx force-pushed the develop branch 3 times, most recently from 9f05f51 to c2f88ad Compare March 26, 2024 06:35
@saxyx saxyx closed this Mar 26, 2024
@cmhughes
Copy link
Owner

Why is this closed?

@saxyx saxyx reopened this Mar 26, 2024
@saxyx
Copy link
Contributor Author

saxyx commented Mar 26, 2024

I deleted the previous commit and made a new one from scratch. Macos executable and Linux executable also encountered the same problem at #531.

@@ -124,8 +124,8 @@ jobs:
$files = Get-ChildItem test-cases\check-switch-tests\*tex
foreach ($file in $files) {perl latexindent.pl --check -s $file}
cjk-windows-exe-test:
needs: check-pm-files-changed
if: ${{fromJSON(needs.check-pm-files-changed.outputs.anychanged)}}
#needs: check-pm-files-changed
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this line and the next line should NOT be commented

needs: check-pm-files-changed
if: ${{fromJSON(needs.check-pm-files-changed.outputs.anychanged)}}
#needs: check-pm-files-changed
#if: ${{fromJSON(needs.check-pm-files-changed.outputs.anychanged)}}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here, and throughout, please

@cmhughes cmhughes merged commit 98bb8cd into cmhughes:develop Mar 28, 2024
2 checks passed
@cmhughes
Copy link
Owner

Great, many thanks for your help on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants