Skip to content

Commit

Permalink
net/netrom: prefer strscpy over strcpy
Browse files Browse the repository at this point in the history
The deprecated helper strcpy() performs no bounds checking on the
destination buffer. This could result in linear overflows beyond
the end of the buffer, leading to all kinds of misbehaviors.
The safe replacement is strscpy() [1].

Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strcpy [1]

Signed-off-by: Hongbo Li <lihongbo22@huawei.com>
Link: https://patch.msgid.link/20240828123224.3697672-4-lihongbo22@huawei.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
  • Loading branch information
Hongbo Li authored and kuba-moo committed Aug 29, 2024
1 parent b19f69a commit 597be7b
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions net/netrom/nr_route.c
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ static int __must_check nr_add_node(ax25_address *nr, const char *mnemonic,
}

nr_node->callsign = *nr;
strcpy(nr_node->mnemonic, mnemonic);
strscpy(nr_node->mnemonic, mnemonic);

nr_node->which = 0;
nr_node->count = 1;
Expand All @@ -214,7 +214,7 @@ static int __must_check nr_add_node(ax25_address *nr, const char *mnemonic,
nr_node_lock(nr_node);

if (quality != 0)
strcpy(nr_node->mnemonic, mnemonic);
strscpy(nr_node->mnemonic, mnemonic);

for (found = 0, i = 0; i < nr_node->count; i++) {
if (nr_node->routes[i].neighbour == nr_neigh) {
Expand Down

0 comments on commit 597be7b

Please sign in to comment.