-
Notifications
You must be signed in to change notification settings - Fork 0
Document timer #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document timer #11
Conversation
v0.3/handbook/libraries/stdlib.md
Outdated
<tr> | ||
<td> | ||
<ul> | ||
<li><strong>resultion</strong> - the frequency in milliseconds of the timer.</li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'resultion' typo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd also describe it as "the frequency in milliseconds for updating the timer."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
read attributes are always optional. Rob was including that for write attributes I think. We also need a clearer way of separating read and write attributes, this would probably be very confusing to somebody unfamiliar with how the timer works.
v0.3/handbook/libraries/stdlib.md
Outdated
<li><strong>seconds</strong> - (optional) - the current second (0 - 59)</li> | ||
<li><strong>milliseconds</strong> - (optional) - the current millisecond (0 - 999)</li> | ||
<li><strong>timestamp</strong> - (optional) - the current time represented as the number of milliseconds elapsed since 1 January 1970 00:00:00 UTC</li> | ||
<li><strong>frame</strong> - (optional) - the number of frames elapsed since the start of the timer</li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to indicate what frame specifically means here (the number of times the timer has ticked). In fact, frame is kind of a bad name for what it is now, I'd probably call it "tick", but I guess we shouldn't block documenting it on fixing the actual watcher.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
v0.3/handbook/libraries/stdlib.md
Outdated
<li><strong>month</strong> - (optional) - the current month (1 - 12)</li> | ||
<li><strong>day</strong> - (optional) - the current day of the month (1 - 31)</li> | ||
<li><strong>weekday</strong> - (optional) - the current day of the week (1 - 7, where 1 is Sunday)</li> | ||
<li><strong>hours</strong> - (optional) - the current hour (0 - 23)</li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we just made all these singular and need to update these now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎂
No description provided.