Skip to content

Conversation

cmontella
Copy link
Owner

No description provided.

<tr>
<td>
<ul>
<li><strong>resultion</strong> - the frequency in milliseconds of the timer.</li>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'resultion' typo

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd also describe it as "the frequency in milliseconds for updating the timer."

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

read attributes are always optional. Rob was including that for write attributes I think. We also need a clearer way of separating read and write attributes, this would probably be very confusing to somebody unfamiliar with how the timer works.

<li><strong>seconds</strong> - (optional) - the current second (0 - 59)</li>
<li><strong>milliseconds</strong> - (optional) - the current millisecond (0 - 999)</li>
<li><strong>timestamp</strong> - (optional) - the current time represented as the number of milliseconds elapsed since 1 January 1970 00:00:00 UTC</li>
<li><strong>frame</strong> - (optional) - the number of frames elapsed since the start of the timer</li>
Copy link
Collaborator

@joshuafcole joshuafcole Jun 23, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to indicate what frame specifically means here (the number of times the timer has ticked). In fact, frame is kind of a bad name for what it is now, I'd probably call it "tick", but I guess we shouldn't block documenting it on fixing the actual watcher.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<li><strong>month</strong> - (optional) - the current month (1 - 12)</li>
<li><strong>day</strong> - (optional) - the current day of the month (1 - 31)</li>
<li><strong>weekday</strong> - (optional) - the current day of the week (1 - 7, where 1 is Sunday)</li>
<li><strong>hours</strong> - (optional) - the current hour (0 - 23)</li>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we just made all these singular and need to update these now

Copy link
Collaborator

@joshuafcole joshuafcole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎂

@cmontella cmontella merged commit 8c33057 into gh-pages Jun 23, 2017
@cmontella cmontella deleted the add/system branch June 23, 2017 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants