Skip to content

Conversation

@sylvestre
Copy link

No description provided.

@sylvestre
Copy link
Author

@cmpute if you could approve the CI run, it would be great, thanks :)

@cmpute
Copy link
Owner

cmpute commented Aug 11, 2024

Thanks for the PR! The CI test failed. The MSRV policy is still 1.57.

@sylvestre
Copy link
Author

@cmpute is there a reason for 1.57 as a minimal dep ? it is quite old now (almost 3 years now)

@cmpute
Copy link
Owner

cmpute commented Aug 12, 2024

@cmpute is there a reason for 1.57 as a minimal dep ? it is quite old now (almost 3 years now)

Not much, but I don't think it's worth to bump the MSRV only for the 'dep:' feature tho.

@sylvestre
Copy link
Author

@cmpute I think I fixed it

I am trying to package num-prime in debian for the rust coreutils :)
This is why I need this bug fixed

@cmpute
Copy link
Owner

cmpute commented Oct 7, 2024

The 1.57 check still failed. I will take a look later

@cmpute
Copy link
Owner

cmpute commented Oct 7, 2024

There is a work around, you can build with "--features num-bigint,num-traits,num-integer".

If it doesn't work for you, then I think the only way is to rename the "num-bigint" dependency, which might requires additional checks on other packages depending on this.

@sylvestre
Copy link
Author

ok, thanks :)

the only way

or upgrade MSRV ;)

@cmpute
Copy link
Owner

cmpute commented Oct 8, 2024

ok, thanks :)

the only way

or upgrade MSRV ;)

Yeah the only way without bumping MSRV haha. Please let me know if enabling all these three features num-bigint,num-traits,num-integer works for you or not. If it suffices, I prefer to close the PR and the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants