-
Notifications
You must be signed in to change notification settings - Fork 5
Improve bignum support (Closes: #9) #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
@cmpute if you could approve the CI run, it would be great, thanks :) |
|
Thanks for the PR! The CI test failed. The MSRV policy is still 1.57. |
|
@cmpute is there a reason for 1.57 as a minimal dep ? it is quite old now (almost 3 years now) |
Not much, but I don't think it's worth to bump the MSRV only for the 'dep:' feature tho. |
|
@cmpute I think I fixed it I am trying to package num-prime in debian for the rust coreutils :) |
|
The 1.57 check still failed. I will take a look later |
|
There is a work around, you can build with "--features num-bigint,num-traits,num-integer". If it doesn't work for you, then I think the only way is to rename the "num-bigint" dependency, which might requires additional checks on other packages depending on this. |
|
ok, thanks :)
or upgrade MSRV ;) |
Yeah the only way without bumping MSRV haha. Please let me know if enabling all these three features |
No description provided.