Combined Module Eff Bug Fix #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomalin
pushed a commit
that referenced
this pull request
Dec 29, 2023
tomalin
pushed a commit
that referenced
this pull request
Mar 7, 2024
tomalin
pushed a commit
that referenced
this pull request
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description:
Changing one line which caused a bug in which combined module efficiency was significantly decreased in high eta/endcap region.
More specifically, this is the link to the line that I changed back to what it was before: 23a8a8c#diff-0c7cf803e613a94ff5b22deb42f152136d1c91cb933f889070380ae102f02094R125
See attached presentation for how the combined modules were affected.
Combined Module Bug.pdf
PR validation:
No tests were done (I was told they were not needed for a simple change like this)