-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add truncation in TrackletProcessorDisplaced #293
Conversation
@cgsavard The only thing I would suggest is adding a separate "TPD" key to the cmssw/L1Trigger/TrackFindingTracklet/interface/Settings.h Lines 883 to 901 in 87c8b05
And then use that instead of "TP" in the code you've added. I can see it being useful being able to turn truncation on and off for the prompt and displaced modules separately. |
Done! |
Thanks, @cgsavard! But you should also change |
@aehart Ah yes, I accidentally added the wrong file to the commit. I just fixed the commit so hopefully everything is good now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I'll let @tomalin merge this, in case he has any comments.
* include truncation in TrackletProcessorDisplaced * code formatting * include separate truncation for TP and TPD
* include truncation in TrackletProcessorDisplaced * code formatting * include separate truncation for TP and TPD
* include truncation in TrackletProcessorDisplaced * code formatting * include separate truncation for TP and TPD
PR description:
Truncation has never been added to the TrackletProcessorDisplaced module and so these changes implement truncation there using the maxstep_['TP'] value in Settings.h here (as the other displaced modules do). Truncation in extended tracking is turned off by default and so this doesn't change the performance of anything, but allows us to properly study truncation for the full extended chain.
PR validation:
After running a couple of checks, the behavior of these changes is exactly as expected. With truncation off, nothing changes. With truncation on, TrackletProcessorDisplaced is capping its processing of objects to the value set in Settings.h.