Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor Fixes on createFimrwareInputFiles_cfg.py #300

Conversation

amastron23
Copy link

  • Fixed Global Tag
  • Valid Geometry for this version of CMSSW (D88 was throwing an error)
  • The option EMPv2 didn't exist in the "format" flag description, but is actually very much needed since it makes the cfg produce the .txt files with the right format (that then empbutler happily accepts and fills the input buffers). The default EMP value produces text files with very old format, so it's good for users to know.

@tomalin
Copy link
Collaborator

tomalin commented Dec 13, 2024

If this PR is more related to the GTT group than to the L1 track community, then it should not be made to fork cms-L1TK. Instead, present it to the GTT group and make a PR directly to central CMSSW. And close this PR ...

@amastron23
Copy link
Author

Hi @tomalin

Yes, do close this. I'll move it to central cmssw.

Thanks,

@amastron23

@tomalin
Copy link
Collaborator

tomalin commented Dec 16, 2024

Closing PR. Suggest @amastron23 makes it directly to central CMSSW.

@tomalin tomalin closed this Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants